feat(storage): hash pins on S3/GCS via object metadata - #951
Closed
devitway wants to merge 1 commit into
Closed
Conversation
Reland of #947 (jgrund), rebased onto main: resolves the CHANGELOG conflict; gc.rs auto-merges cleanly with #950. Also adds a direct validate_storage_key() at the top of Storage::get() (defense-in-depth, mirrors get_verified) so the trust-boundary invariant is not left to transitive get_pinned() validation. Gate green: fmt/clippy/test (63+1781/0), OPSEC clean, trust-boundary 13/13 SAFE, polygon A/B (pin rides as x-amz-meta-sha256, bad Repr-Digest -> 400). Closes #947
|
🐳 Test image pushed: docker pull ghcr.io/getnora-io/nora:pr-951
docker run --rm -p 4000:4000 ghcr.io/getnora-io/nora:pr-951 |
ertime037
approved these changes
Sep 4, 2026
ertime037
enabled auto-merge
September 4, 2026 07:15
devitway
added
the
reland
Contributor
Author
|
Superseded by #952 — same reviewed diff re-landed as one web-flow-signed commit (main requires verified signatures; these commits were unsigned). Closing. Note: the |
devitway
removed
the
reland
auto-merge was automatically disabled
September 4, 2026 07:23
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #947 (by @jgrund), rebased onto current
main.Records the SHA-256 integrity pin as object metadata (
x-amz-meta-sha256/x-goog-meta-sha256) on the S3 and GCS backends. The pin is written atomically with the object (onput_opts/ the multipart init), so an object is never stored without its pin;getre-verifies the pin on read and fails closed on a mismatch. Raw uploads are additionally validated against an RFC 9530Repr-Digestheader when present.Also adds a direct
validate_storage_key()at the top ofStorage::get()for defense in depth.Closes #947